Skip to content

#491 - CounterTask: reject flush_every 0, deprecate a negative value - #492

Merged
njoubert-cleverage merged 1 commit into
mainfrom
491
Nov 6, 2026
Merged

njoubert-cleverage merged 1 commit into
mainfrom
491

Conversation

@njoubert-cleverage

@njoubert-cleverage njoubert-cleverage commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

Description

Fixes #491:

  • CounterTask: flush_every: 0 is rejected when the options are resolved (InvalidOptionsException with a clear message), instead of Modulo by zero at the first execution;
  • a negative flush_every, which works as its absolute value, is deprecated since 5.10 (rejected in v6.0); documentation and UPGRADE.

Checked locally: highest dependencies (PHP 8.5.12), with pcov coverage: all tests OK, no risky; PHPStan, PHP-CS-Fixer and Rector OK.

Requirements

  • Documentation updates
    • Reference
    • Cookbooks
    • Changelog
  • Unit tests

Breaking changes

None: 0 never worked.

🤖 Generated with Claude Code

@njoubert-cleverage
njoubert-cleverage requested a review from a team as a code owner November 6, 2026 13:14
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@njoubert-cleverage
njoubert-cleverage merged commit 4f37143 into main Nov 6, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CounterTask: flush_every 0 fails with Modulo by zero

1 participant